Skip to content

Conversation

@JanezStupar
Copy link
Contributor

Under the hood sql_crdt operates with explicit parameter indices (?1, ?2. ?3,... ) which leads to conflicts whenever a client uses implicit parameter indexing (?, ?, ?,... ).

This PR ensures parameter conversion from implicit to explicit.

@cachapa
Copy link
Owner

cachapa commented May 2, 2025

Thanks, Janez!
It seems the format check failed, would you mind having a look? Otherwise I can fix it on my end.

@JanezStupar
Copy link
Contributor Author

Hey Daniel, that is a bit awkward, but running dart format on my local machine changes nothing, both with dart 3.7.2 and 3.8.0, I see that github ran 3.7.3?

I tried to run the workflow locally but got stuck in networking stuff (it expects ipv6, which doesn't work in my network because of reasons) so at this point I would be extremely grateful if you could have a look at this.

@cachapa
Copy link
Owner

cachapa commented May 3, 2025

I think I see the problem - the GitHub runner seems to be running a more recent version of Dart than the one shipped with Flutter.

I'm having the same issue in other projects. Let's just ignore it for now.

Thanks again for your effort!

@cachapa cachapa merged commit 57283b4 into cachapa:master May 3, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants