Restore separation of concerns between internal modules#41
Merged
marktsuchida merged 3 commits intomainfrom Jan 19, 2026
Merged
Restore separation of concerns between internal modules#41marktsuchida merged 3 commits intomainfrom
marktsuchida merged 3 commits intomainfrom
Conversation
Move the vendor/jdk listing implementations to the relevant internal modules so that _api is not reaching for private symbols. Fix an issue caused by microsoft-openjdk, which does not have the jdk@ prefix in the index. Ignore it for now (we can add support later). If we include it, it fails on later queries because jdk@microsoft-openjdk won't be found. It caused `cjdk ls --available` to fail. (Assisted by Claude Code; any errors are mine.)
(Partially assisted by Claude Code; any errors are mine.)
Where it better belongs. Now _index is back to an implementation detail of _jdk. (Assisted by Claude Code; any errors are mine.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.