🐛fix: Update JSDOM to latest version v25.0.1#36
Open
adambullmer wants to merge 2 commits intocaderek:mainfrom
Open
🐛fix: Update JSDOM to latest version v25.0.1#36adambullmer wants to merge 2 commits intocaderek:mainfrom
adambullmer wants to merge 2 commits intocaderek:mainfrom
Conversation
Resolves deprecation notice of punycode in node 22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves deprecation notice of punycode in node 22 (lts/jod). This deprecation notice is not present in the previous node lts/iron. This PR updates to the latest possible version of JSDOM, which does reduce some possible node versions to a minimum of 18, and updates the
initcommand package values accordingly. Otherwise JSDOM doesn't appear to have any breaking changes for the usage in aocrunner.Example of the error:
This is caused by the direct dependency on JSDOM, which has several nested dependencies linking to
tr46@3.0.0. This dependency already has a fix, and can readily be consumed in any JSDOM >= 21.0.0.