Skip to content

🐛fix: Update JSDOM to latest version v25.0.1#36

Open
adambullmer wants to merge 2 commits intocaderek:mainfrom
adambullmer:main
Open

🐛fix: Update JSDOM to latest version v25.0.1#36
adambullmer wants to merge 2 commits intocaderek:mainfrom
adambullmer:main

Conversation

@adambullmer
Copy link

Resolves deprecation notice of punycode in node 22 (lts/jod). This deprecation notice is not present in the previous node lts/iron. This PR updates to the latest possible version of JSDOM, which does reduce some possible node versions to a minimum of 18, and updates the init command package values accordingly. Otherwise JSDOM doesn't appear to have any breaking changes for the usage in aocrunner.

Example of the error:

?  › (node:44534) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:399:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:338:10)
    at loadBuiltinModule (node:internal/modules/helpers:112:7)
    at Function._load (node:internal/modules/cjs/loader:1100:17)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:219:24)
    at Module.require (node:internal/modules/cjs/loader:1340:12)
    at require (node:internal/modules/helpers:138:16)
    at Object.<anonymous> (/path/to/repo/node_modules/tr46/index.js:3:18)

This is caused by the direct dependency on JSDOM, which has several nested dependencies linking to tr46@3.0.0. This dependency already has a fix, and can readily be consumed in any JSDOM >= 21.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant