If an adopter disconnects in between animation frames, it throws an error during restyling#112
Open
jorgea-stripe wants to merge 2 commits intocalebdwilliams:mainfrom
Open
If an adopter disconnects in between animation frames, it throws an error during restyling#112jorgea-stripe wants to merge 2 commits intocalebdwilliams:mainfrom
jorgea-stripe wants to merge 2 commits intocalebdwilliams:mainfrom
Conversation
Author
|
@calebdwilliams would appreciate any feedback or a review for this fix! |
Owner
|
@jorgea-stripe looks like the tests failed. |
Author
|
@calebdwilliams - I believe my latest change should fix the test that broke due to an outdated browser message! (I've run it locally however I don't have permission to run on the CI) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While callers of
restyleAdoptercheck if their adopters are connected,restyleAdoptercontains a call torequestAnimationFramewhich means that adopters can be disconnected while the browser is waiting for the next repaint.Here's the error that is thrown under those circumstances:
.
This error bubbles up as an unhandled exception in certain apps (like in this NextJS setup):
, as well as in the console.
The fix is to take into account that nodes may become disconnected in the callback of
requestAnimationFrame. With this update, I can no longer repro this race condition.