feat(llama): unify provider implementation with Apple/MLC patterns #170
+129
−234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add rawCall to doStream return value for consistency - Add providerMetadata to doGenerate response - Remove excessive console logging throughout streaming - Fix error handling consistency (polyfill message, error wrapping) - Remove unnecessary try-catch blocks to match Apple provider - Unify README documentation style with Apple provider - Add Mike Grabowski to contributors - Remove react-native-blob-util from expo-example (transitive dependency) - Update llama documentation to remove blob-util from installation - Update MLC README with download/prepare steps for completeness
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
I have also removed flags isCancelled etc., since we cancel the stream and will close the controller in the last chunk. This is aligned with how we do it for Apple. Any changes to this behavior - best if we do it once for all providers. |
artus9033
approved these changes
Jan 15, 2026
Contributor
artus9033
left a comment
artus9033
left a comment
There was a problem hiding this comment.
LGTM! Always happy to unify :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the @react-native-ai/llama provider implementation with the Apple and MLC providers for consistency across the codebase.
Core Implementation Changes
Documentation & Dependencies