-
Notifications
You must be signed in to change notification settings - Fork 14
feat(test): Add traceability requirements #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): Add traceability requirements #39
Conversation
c81d9d9 to
85ff7fc
Compare
|
CCT-1063 was Closed as a duplicate of CCT-1311. Please start using CCT-1311 in all your jira references. |
|
It looks like that there is some incompatibility in unit test on Fedora 42, which contains new version of Python (something like method |
85ff7fc to
afffd8c
Compare
afffd8c to
510697b
Compare
510697b to
ab399e7
Compare
jirihnidek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testimony validation job failed with error saying that 100% of doc strings is wrong: Total number of invalid docstrings: 74 (100.00%). I do not understand why. Message like this does not say me anything useful:
TestUnicode::test_unicode_with_bom:89
-------------------------------------
* Tokens with invalid values:
Polarion-project-id: RHELSS
type: choice
case sensitive: False
choices: ['test-polarion-id']
Requirement: RHSS-291606
type: choice
case sensitive: False
choices: ['test-requirement']
2e9643b to
6cdb8b4
Compare
6cdb8b4 to
d119679
Compare
jirihnidek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for update. Can you please not remove existing doc string completely that confuses betelgeuse? Can you please convert these "confusing" doc strings to comments? I do not want to lost existing information
d119679 to
93c3874
Compare
jirihnidek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for update 👍 I have one small request.
The intention of CCT-1311 is to add a gating.el10 job for python-iniparse. Before that it would be good to have the traceability matrix to be able to report our tests to Polarion. This PR therefore adds the neccessary docstrings for Betelgeuse to each test. It also adds two github workflows - checks for betelgeuse and for testimony so that on every PR we have a check that the tests have these requirements.
Small change of removing the warning message.
93c3874 to
da1ad48
Compare
jirihnidek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The intention of CCT-1311 is to add a gating.el10 job for python-iniparse. Before that it would be good to have the traceability matrix to be able to report our tests to Polarion. This PR therefore adds the neccessary docstrings for Betelgeuse to each test. It also adds two github workflows - checks for betelgeuse and for testimony so that on every PR we have a check that the tests have these requirements.