Skip to content

Conversation

@zpetrace
Copy link
Contributor

@zpetrace zpetrace commented Apr 16, 2025

The intention of CCT-1311 is to add a gating.el10 job for python-iniparse. Before that it would be good to have the traceability matrix to be able to report our tests to Polarion. This PR therefore adds the neccessary docstrings for Betelgeuse to each test. It also adds two github workflows - checks for betelgeuse and for testimony so that on every PR we have a check that the tests have these requirements.

@zpetrace zpetrace force-pushed the zpetrace/add-traceability-matrix branch from c81d9d9 to 85ff7fc Compare April 16, 2025 20:29
@jsefler
Copy link

jsefler commented Apr 17, 2025

CCT-1063 was Closed as a duplicate of CCT-1311. Please start using CCT-1311 in all your jira references.

@jirihnidek
Copy link
Collaborator

It looks like that there is some incompatibility in unit test on Fedora 42, which contains new version of Python (something like method xyz has been deprecated for a while and now it is completely removed). We should fix this issue in another PR before merging this PR.

@zpetrace zpetrace force-pushed the zpetrace/add-traceability-matrix branch from 85ff7fc to afffd8c Compare April 25, 2025 11:27
@zpetrace zpetrace force-pushed the zpetrace/add-traceability-matrix branch from afffd8c to 510697b Compare May 12, 2025 12:07
@zpetrace zpetrace marked this pull request as ready for review May 12, 2025 12:08
@zpetrace zpetrace force-pushed the zpetrace/add-traceability-matrix branch from 510697b to ab399e7 Compare May 12, 2025 12:16
@zpetrace zpetrace requested a review from Lorquas May 12, 2025 12:18
Copy link
Collaborator

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testimony validation job failed with error saying that 100% of doc strings is wrong: Total number of invalid docstrings: 74 (100.00%). I do not understand why. Message like this does not say me anything useful:

TestUnicode::test_unicode_with_bom:89
-------------------------------------

* Tokens with invalid values:
  Polarion-project-id: RHELSS
      type: choice
      case sensitive: False
      choices: ['test-polarion-id']
  Requirement: RHSS-291606
      type: choice
      case sensitive: False
      choices: ['test-requirement']

@zpetrace zpetrace force-pushed the zpetrace/add-traceability-matrix branch 2 times, most recently from 2e9643b to 6cdb8b4 Compare May 20, 2025 08:51
@zpetrace zpetrace requested a review from jirihnidek May 27, 2025 09:34
@zpetrace zpetrace force-pushed the zpetrace/add-traceability-matrix branch from 6cdb8b4 to d119679 Compare May 27, 2025 10:44
Copy link
Collaborator

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update. Can you please not remove existing doc string completely that confuses betelgeuse? Can you please convert these "confusing" doc strings to comments? I do not want to lost existing information

@zpetrace zpetrace force-pushed the zpetrace/add-traceability-matrix branch from d119679 to 93c3874 Compare June 3, 2025 09:17
@zpetrace zpetrace requested a review from jirihnidek June 3, 2025 09:18
Copy link
Collaborator

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update 👍 I have one small request.

zpetrace added 2 commits June 3, 2025 12:33
The intention of CCT-1311 is to add a gating.el10 job for python-iniparse.
Before that it would be good to have the traceability matrix to
be able to report our tests to Polarion. This PR therefore adds the
neccessary docstrings for Betelgeuse to each test. It also adds two
github workflows - checks for betelgeuse and for testimony so that
on every PR we have a check that the tests have these requirements.
Small change of removing the warning message.
@zpetrace zpetrace force-pushed the zpetrace/add-traceability-matrix branch from 93c3874 to da1ad48 Compare June 3, 2025 10:35
@zpetrace zpetrace requested a review from jirihnidek June 3, 2025 10:36
Copy link
Collaborator

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jirihnidek jirihnidek merged commit d750fe1 into candlepin:main Jun 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants