Skip to content

Make graphics render check more flexible (bugfix) #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rickwu666666 wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Make graphics render check more flexible (bugfix) #2233

rickwu666666 wants to merge 24 commits into from

Conversation

@rickwu666666
Copy link
Contributor

@rickwu666666 rickwu666666 commented Dec 9, 2025 •
edited
Loading

Description

Rewrite the script in python and make the matching logic more flexible for GL_VENDOR and GL_RENDERER, since in some case it will report the GL_RENDERER with the version behind but we care about only the renderer it self.

Resolved issues

Documentation

Tests

Sideload result

=========[ Running job 1 / 1. Estimated time left (at least): 0:00:00 ]=========                                                                                                        
---------------[ Run OpenGL ES 2.0 Wayland benchmark on the GPU ]---------------                                                                                                        
ID: com.canonical.contrib::mir/glmark2-es2-wayland-auto                                                                                                                                 
Category: com.canonical.contrib::mir_test                                                                                                                                                                                             
... 8< -------------------------------------------------------------------------                                                                                                                                                      
2025-12-09 05:41:56,575 - INFO - The ubuntu-frame is active                                                                                                                                                                                                           
2025-12-09 05:41:56,577 - INFO - Running glmark2-es2-wayland benchmark...                                                                                                                                                                                             
2025-12-09 05:41:57,821 - INFO - WARNING: x11 interface not connected! Please run: /snap/graphics-test-tools/current/bin/setup.sh                                                                                                                                     
2025-12-09 05:41:57,999 - INFO - Could not open module param file '/sys/module/mali_kbase/parameters/large_page_conf'                                                                                                                                                 
2025-12-09 05:41:58,100 - INFO - =======================================================                                                                                                                                                                              
2025-12-09 05:41:58,104 - INFO - glmark2 2023.01                                                                                                                                        
2025-12-09 05:41:58,105 - INFO - =======================================================                                                                                                                                                                                                                          
2025-12-09 05:41:58,105 - INFO - OpenGL Information                                                                                                                                                                                   
2025-12-09 05:41:58,115 - INFO - GL_VENDOR:      ARM                                                                                                                                                                                                                                                              
2025-12-09 05:41:58,119 - INFO - GL_RENDERER:    Mali-G31                                                                                                                                                                                                                                                         
2025-12-09 05:41:58,123 - INFO - GL_VERSION:     OpenGL ES 3.2 v1.r50p0-00eac0.9e625e4a80ebab2bc0b93f0394937ef0                                                                                                                                                                                                   
2025-12-09 05:41:58,125 - INFO - Surface Config: buf=32 r=8 g=8 b=8 a=8 depth=24 stencil=0 samples=0                                                                                    
2025-12-09 05:41:58,135 - INFO - Surface Size:   800x600 windowed                                                                                                                                                                                                                                                 
2025-12-09 05:41:58,140 - INFO - =======================================================                                                                                                                                              
2025-12-09 05:42:08,352 - INFO - [build] use-vbo=false: FPS: 114 FrameTime: 8.839 ms                                                                                                    
2025-12-09 05:42:18,484 - INFO - [build] use-vbo=true: FPS: 121 FrameTime: 8.299 ms                                                                                                                                                   
2025-12-09 05:42:28,631 - INFO - [texture] texture-filter=nearest: FPS: 117 FrameTime: 8.571 ms                                                                                         
2025-12-09 05:42:38,749 - INFO - [texture] texture-filter=linear: FPS: 120 FrameTime: 8.401 ms                                                                                                                                        
2025-12-09 05:42:48,849 - INFO - [texture] texture-filter=mipmap: FPS: 127 FrameTime: 7.921 ms                                                                                                                                        
2025-12-09 05:42:58,979 - INFO - [shading] shading=gouraud: FPS: 110 FrameTime: 9.097 ms                                                                                                                                                                              
2025-12-09 05:43:09,168 - INFO - [shading] shading=blinn-phong-inf: FPS: 108 FrameTime: 9.299 ms                                                                                                                                                                      
2025-12-09 05:43:19,330 - INFO - [shading] shading=phong: FPS: 99 FrameTime: 10.106 ms                                                                                                                                                                                
2025-12-09 05:43:29,530 - INFO - [shading] shading=cel: FPS: 96 FrameTime: 10.496 ms                                                                                                                                                                                  
2025-12-09 05:43:39,838 - INFO - [bump] bump-render=high-poly: FPS: 72 FrameTime: 13.961 ms                                                                                                                                           
2025-12-09 05:43:50,042 - INFO - [bump] bump-render=normals: FPS: 133 FrameTime: 7.546 ms                                                                                                                                             
2025-12-09 05:44:00,280 - INFO - [bump] bump-render=height: FPS: 121 FrameTime: 8.299 ms                                                                                                                                              
2025-12-09 05:44:10,388 - INFO - [effect2d] kernel=0,1,0;1,-4,1;0,1,0;: FPS: 104 FrameTime: 9.623 ms                                                                                                                                                                                                              
2025-12-09 05:44:20,513 - INFO - [effect2d] kernel=1,1,1,1,1;1,1,1,1,1;1,1,1,1,1;: FPS: 56 FrameTime: 17.938 ms                                                                                                                                                                                                   
2025-12-09 05:44:30,604 - INFO - [pulsar] light=false:quads=5:texture=false: FPS: 123 FrameTime: 8.157 ms                                                                                                                                                                                                         
2025-12-09 05:44:41,400 - INFO - [desktop] blur-radius=5:effect=blur:passes=1:separable=true:windows=4: FPS: 42 FrameTime: 24.089 ms                                                                                                                                                                              
2025-12-09 05:44:51,542 - INFO - [desktop] effect=shadow:windows=4: FPS: 88 FrameTime: 11.404 ms                                                                                                                                      
2025-12-09 05:45:01,802 - INFO - [buffer] columns=200:interleave=false:update-dispersion=0.9:update-fraction=0.5:update-method=map: FPS: 38 FrameTime: 26.858 ms                                                                                                                                                  
2025-12-09 05:45:12,087 - INFO - [buffer] columns=200:interleave=false:update-dispersion=0.9:update-fraction=0.5:update-method=subdata: FPS: 38 FrameTime: 26.591 ms                                                                                                                                              
2025-12-09 05:45:22,330 - INFO - [buffer] columns=200:interleave=true:update-dispersion=0.9:update-fraction=0.5:update-method=map: FPS: 54 FrameTime: 18.652 ms                                                                                                                                                                                                                 
2025-12-09 05:45:33,546 - INFO - [ideas] speed=duration: FPS: 62 FrameTime: 16.182 ms                                                                                                                                                                                                                                                                                           
2025-12-09 05:45:44,333 - INFO - [jellyfish] <default>: FPS: 74 FrameTime: 13.538 ms                                                                                                    
2025-12-09 05:45:56,546 - INFO - [terrain] <default>: FPS: 8 FrameTime: 134.304 ms                                                                                                      
2025-12-09 05:46:07,095 - INFO - [shadow] <default>: FPS: 69 FrameTime: 14.606 ms                                                                                                                                                                                                                                 
2025-12-09 05:46:19,897 - INFO - [refract] <default>: FPS: 19 FrameTime: 53.504 ms                                                                                                                                                    
2025-12-09 05:46:30,032 - INFO - [conditionals] fragment-steps=0:vertex-steps=0: FPS: 125 FrameTime: 8.046 ms                                                                                                                                                                                                     
2025-12-09 05:46:40,147 - INFO - [conditionals] fragment-steps=5:vertex-steps=0: FPS: 97 FrameTime: 10.340 ms                                                                                                                                                                                                     
2025-12-09 05:46:50,276 - INFO - [conditionals] fragment-steps=0:vertex-steps=5: FPS: 119 FrameTime: 8.432 ms                                                                                                                                                                                                     
2025-12-09 05:47:00,409 - INFO - [function] fragment-complexity=low:fragment-steps=5: FPS: 115 FrameTime: 8.757 ms                                                                                                                                                                                                
2025-12-09 05:47:10,540 - INFO - [function] fragment-complexity=medium:fragment-steps=5: FPS: 90 FrameTime: 11.197 ms                                                                                                                                                                                             
2025-12-09 05:47:20,681 - INFO - [loop] fragment-loop=false:fragment-steps=5:vertex-steps=5: FPS: 113 FrameTime: 8.892 ms                                                                                                                                                                                                                                                                                                                                                   
2025-12-09 05:47:30,801 - INFO - [loop] fragment-steps=5:fragment-uniform=false:vertex-steps=5: FPS: 116 FrameTime: 8.688 ms                                                                                                                                                                                                                                                                                                                                                
2025-12-09 05:47:40,960 - INFO - [loop] fragment-steps=5:fragment-uniform=true:vertex-steps=5: FPS: 98 FrameTime: 10.282 ms                                                                                                           
2025-12-09 05:47:40,967 - INFO - =======================================================                                                                                                                                              
2025-12-09 05:47:40,978 - INFO - glmark2 Score: 89                                                                                                       
2025-12-09 05:47:40,981 - INFO - =======================================================                                                                 
2025-12-09 05:47:42,132 - INFO - PASS: GL_VENDOR is 'AR'                                                                                                 
2025-12-09 05:47:42,136 - INFO - PASS: GL_RENDERER is 'Mali'                                                                                                                                                                                                                                                      
------------------------------------------------------------------------- >8 ---                                                                                                                                                                                                                                  
Outcome: job passed

@rickwu666666 rickwu666666 requested a review from a team December 9, 2025 05:52
@rickwu666666 rickwu666666 added the ce-oem The PR only contains to the ce-oem provider under the contrib area label Dec 9, 2025
@rickwu666666 rickwu666666 changed the title Make graphics render check more flexibility Make graphics render check more flexibility (bugfix) Dec 9, 2025
@rickwu666666 rickwu666666 changed the title Make graphics render check more flexibility (bugfix) Make graphics render check more flexible (bugfix) Dec 9, 2025
@rickwu666666 rickwu666666 force-pushed the make-graphics-render-check-more-flexibility branch from 2e45d1c to 9f6d9a4 Compare December 9, 2025 07:24
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.69%. Comparing base (1b7ffef) to head (9f6d9a4).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2233   +/-   ##
=======================================
  Coverage   53.69%   53.69%           
=======================================
  Files         401      401           
  Lines       43145    43145           
  Branches     7996     7996           
=======================================
  Hits        23167    23167           
  Misses      19161    19161           
  Partials      817      817

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rickwu666666
Move config variables check at the first
eacbcc1 
Use subprocess.check_output instead of Popen. This change will cause the test log only present after glmark2 test finished. However, it should be fine since this is a automation job
@rickwu666666
Modify unittest for the code change
cbbd059
@rickwu666666
Fix black format
ad6d0fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomli380576 tomli380576 Awaiting requested review from tomli380576

@stanley31huang stanley31huang Awaiting requested review from stanley31huang

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ce-oem The PR only contains to the ce-oem provider under the contrib area

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rickwu666666 @tomli380576 @stanley31huang