Port Pick/Place demo to ROS 2#29
Open
DaniGarciaLopez wants to merge 16 commits intocaptain-yoshi:ros2from
Open
Port Pick/Place demo to ROS 2#29DaniGarciaLopez wants to merge 16 commits intocaptain-yoshi:ros2from
DaniGarciaLopez wants to merge 16 commits intocaptain-yoshi:ros2from
Conversation
We must stop the planning thread fast when the halt() method is invoked. https://www.behaviortree.dev/docs/guides/asynchronous_nodes#the-problem-with-multi-threading
* [refac] template stage/container moves to container/task * [fix] container double delete Remove container OutputPort. Pass directly the task to add stages. * Update examples
--------- Co-authored-by: bob <berg0401@usherbrooke.ca> Co-authored-by: Captain Yoshi <captain.yoshisaur@gmail.com>
* Pass properties by their parent * [cleanup] Add comments + update stage/container moving to new API --------- Co-authored-by: bob <berg0401@usherbrooke.ca> Co-authored-by: Captain Yoshi <captain.yoshisaur@gmail.com>
Gives the user a chance to connect to Groot2.
No need to remap the task solution topic manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting the recent commits done in the master branch to ROS 2.
The main changes I made are that I followed a similar approach to moveit_task_constructor_demo to launch the pick and place demo (check the readme). I reused their launch file to bring up the robot and rviz (that's why I also deleted the rviz file) and launched
run.launch.pyto run the BT executor. This is especially important in ROS 2 because the task and the pipeline planner require an instance of the node so they get all moveit parameters from it, so setting up a launch file is much more convenient. We could also adopt a similar approach as they use with theexecparameter to launch different examples, although I agree with the roadmap to convert the current examples to tests.Feel free to merge it now or wait until the 1.0 release 👍