Skip to content

Add cartesi/rollups-database container image release #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
endersonmaia merged 2 commits into from
Mar 24, 2025
Merged

Add cartesi/rollups-database container image release #204

endersonmaia merged 2 commits into from
Mar 24, 2025

Conversation

@endersonmaia
Copy link
Contributor

@endersonmaia endersonmaia commented Mar 21, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: f99284b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@endersonmaia endersonmaia requested a review from tuler March 21, 2025 19:17
@endersonmaia endersonmaia self-assigned this Mar 21, 2025
tuler
tuler reviewed Mar 21, 2025
View reviewed changes
Copy link
Member

@tuler tuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a new workflow for each image, or is it better to have a single workflow for the "sdk" project that takes care of all images, because they follow the same trigger and same versioning.

@endersonmaia
Copy link
Contributor Author

endersonmaia commented Mar 21, 2025

Do we need a new workflow for each image, or is it better to have a single workflow for the "sdk" project that takes care of all images, because they follow the same trigger and same versioning.

Yeah, I'll send a fixup and see how it goes.

@endersonmaia endersonmaia force-pushed the feature/rollups-database-image branch from a27155a to f99284b Compare March 21, 2025 19:36
@endersonmaia endersonmaia requested a review from tuler March 21, 2025 19:37
@endersonmaia endersonmaia mentioned this pull request Mar 21, 2025
Merged
@endersonmaia
Copy link
Contributor Author

endersonmaia commented Mar 24, 2025 •
edited
Loading

Do we need a new workflow for each image, or is it better to have a single workflow for the "sdk" project that takes care of all images, because they follow the same trigger and same versioning.

I couldn't manage to make docker/metadata-action define the tag and annotations for multiple bake targets without making it more complicated than just replicating the workflow files.

@endersonmaia endersonmaia merged commit 5343b63 into feature/sdk-extra-images Mar 24, 2025
6 checks passed
@endersonmaia endersonmaia deleted the feature/rollups-database-image branch March 24, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuler tuler tuler approved these changes

Assignees

@endersonmaia endersonmaia

Labels

sdk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@endersonmaia @tuler