Skip to content

Conversation

@tuler
Copy link
Member

@tuler tuler commented Jan 8, 2026

This migrates from pnpm to bun as the package manager, and from node to bun as runtime platform.

@tuler tuler requested a review from endersonmaia January 8, 2026 00:41
@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2026

🦋 Changeset detected

Latest commit: db19c6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 90.56% 288 / 318
🔵 Statements 90.15% 293 / 325
🔵 Functions 91.22% 52 / 57
🔵 Branches 74.17% 112 / 151
File CoverageNo changed files found.
Generated in workflow #730 for commit db19c6f by the Vitest Coverage Report Action

@tuler
Copy link
Member Author

tuler commented Jan 8, 2026

As far as I understand the release workflow is broken, because changeset publish is not compatible with bun yet, it only works with npm and pnpm.

We also need to understand how we are going to publish in case we opt for binaries produced by bun build --compile, as it's implemented right now. One idea is to use brew on Mac, and apt-get on Linux, but this still needs to be implemented.

@endersonmaia
Copy link
Contributor

We also need to understand how we are going to publish in case we opt for binaries produced by bun build --compile, as it's implemented right now. One idea is to use brew on Mac, and apt-get on Linux, but this still needs to be implemented.

I think we could release the binaries via GitHub Releases at first, and think about brew and apt-get later.

@tuler
Copy link
Member Author

tuler commented Jan 8, 2026

I think we could release the binaries via GitHub Releases at first, and think about brew and apt-get later.

I changed the build process to do both for now.

  1. produce dist/index.js as a minified bundle targeting nodejs. This should work as it is now, packaged and published to npmjs and executed with nodejs.
  2. produce binaries at bin/cartesi-${os}-${arch}

I did not change the release workflow yet to save the binaries in the release. We need to see how to do that.

@tuler tuler requested a review from brunomenezes January 8, 2026 14:22
@tuler tuler force-pushed the feature/ts-compose-builder branch from b427cf8 to d93b34e Compare January 8, 2026 23:23
@tuler tuler force-pushed the feature/bun branch 2 times, most recently from b32dd61 to 5f03e10 Compare January 8, 2026 23:26
@tuler tuler marked this pull request as ready for review January 8, 2026 23:26
Base automatically changed from feature/ts-compose-builder to prerelease/v2-alpha January 9, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants