Skip to content

Conversation

@vfusco
Copy link
Contributor

@vfusco vfusco commented Nov 13, 2025

No description provided.

@vfusco vfusco self-assigned this Nov 13, 2025
@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
dave Ignored Ignored Nov 13, 2025 4:48pm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes small improvements to the build and test infrastructure by specifying the exact Lua version and adding convenience targets for common development tasks.

  • Updated Lua interpreter from lua to lua5.4 to match documented dependencies
  • Added build-devnet wrapper target for building development network
  • Added test-rollups-honeypot-case wrapper target for running individual honeypot test cases

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
prt/tests/rollups/justfile Updates Lua command to use explicit version 5.4 as specified in project dependencies
justfile Adds convenience wrapper targets for building devnet and running individual honeypot test cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@guidanoli
Copy link
Collaborator

The build is failing because the Cannon package was published to the Cannon registry...
When we make the change on Cartesi Rollups to not use Cannon for devnet build, we will do the same here on the Dave repo and then we can merge your PR. What do you think?

@GCdePaula
Copy link
Collaborator

Looks good to me! Can you rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants