fix(docker): improve dockerized environment setup #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henriquemarlon
force-pushed
the
fix/dockerized-env-tests
branch
2 times, most recently
from
00de89c to
fd7b8c7
Compare
henriquemarlon
force-pushed
the
fix/dockerized-env-tests
branch
from
fd7b8c7 to
543cc2c
Compare
henriquemarlon
changed the title
guidanoli
reviewed
Dec 11, 2025
| apt-get update && apt-get install -y --no-install-recommends curl ca-certificates git | ||
| curl -L https://foundry.paradigm.xyz | bash | ||
| ~/.foundry/bin/foundryup --install stable | ||
| ~/.foundry/bin/foundryup --install v1.4.0 |
Collaborator
There was a problem hiding this comment.
We should install Foundry 1.4.3 to match the version used in the CI.
Suggested change
| ~/.foundry/bin/foundryup --install v1.4.0 | |
| ~/.foundry/bin/foundryup --install v1.4.3 |
| rm -rf /var/cache/apt; | ||
|
|
||
| # install pnpm | ||
| RUN wget -qO- https://get.pnpm.io/install.sh | ENV="$HOME/.bashrc" SHELL="$(which bash)" bash - |
There was a problem hiding this comment.
I suggest defining a pnpm version.
Also, Is there any other way to install pnpm ?
I personally don't like running a .sh script from a web requests, for a number of reasons.
Collaborator
There was a problem hiding this comment.
If we install corepack and enable it, it will (download, if necessary, and) use the correct version of pnpm automatically, because all package.json have the packageManager field set to pnpm@10.7.0.
Collaborator
There was a problem hiding this comment.
+1 for pinning versions and (if possible) not running arbitrary bash scripts from the internet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.