You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
MapBuilderOptions will be saved to the AllTrajectoryOptions proto, to be renamed as AllOptions or BuilderOptions (open to suggestions for the naming)
the pbstream info tool can be used to recover them afterwards; no support for directly loading the embedded node options in cartographer_ros is planned (sad face :) )
options for saving other user data:
users save their own protos at the beginning of the proto stream using the Writer API, then hand off the Writer to Cartographer for serialization
pros: users do not have to go through the entire stream to get to their data
cons: the produced streams will not be able to be used with upstream Cartographer, since it does not know how to skip until it hits the Header proto
users can expand the SerializedData proto with their own type and write out their own SerializedData protos using the Writer API after Cartographer is finished with serializing
pros: upstream Cartographer can ignore these in its huge SerializedData proto-type switch, no upstream changes necessary
cons: without interventions into Cartographer, there is no possibility to write the user data at the beginning of the proto stream, only at the end, which can be slow for large streams
similarly to the description in the RFC, SerializedData gets an Any field, and users hand off a vector of Any protos to Cartographer so it can write them out at the beginning (after the header)
- pros: user data is at the beginning so can be accessed fast
- cons: upstream Cartographer needs to be taught to do this, API change required
Okay, the first part (options proto rename + storing map builder options) is in cartographer-project/cartographer#1504. I'll wait for your feedback for the other one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered