feat: verify account via lookup API during session authorization#49
Merged
feat: verify account via lookup API during session authorization#49
Conversation
When --account is provided, look up the username via the Cartridge API to verify it resolves to a controller address before proceeding. Display the username and address in the output and pass account as a URL param. Also fix all clippy warnings in marketplace commands. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--accountis provided duringsession auth, look up the username via the Cartridge lookup API to verify it resolves to a controller addressaccountas a URL parameter in the authorization URLTest plan
controller session auth --account <valid-username> --preset <preset>and verify it shows "Authorizing session for account ()"controller session auth --account <invalid-username> --preset <preset>and verify it errors with "Account not found"controller session auth --preset <preset>(no --account) and verify existing behavior is unchanged🤖 Generated with Claude Code