/rss now results in an rss feed of all the videos#3
Open
wchristian wants to merge 1 commit intocastaway:masterfrom
Open
/rss now results in an rss feed of all the videos#3wchristian wants to merge 1 commit intocastaway:masterfrom
wchristian wants to merge 1 commit intocastaway:masterfrom
Conversation
Owner
|
This looks pretty good.. However can you please optimize the DB query a bit? You should be able to pull all the videos pre-sorted by announcement date, without having to loop over them and fetch each announcement separately. (using join and order_by) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First sketch of an RSS feed of all the videos. Not sure what i should do about the content of each entry or what other metadata should be added. https://metacpan.org/module/Catalyst::View::XML::Feed can provide inspiration for that. I'm also thinking this should be cached until another video is uploaded, but i'm unsure how to implement that. If it is an issue, please advise. :)