Fix-Update namespace restoration logic to respect existingResourcePolicy#13
Open
sshende-catalogicsoftware wants to merge 1 commit intov1.14.0.xfrom
Open
Fix-Update namespace restoration logic to respect existingResourcePolicy#13sshende-catalogicsoftware wants to merge 1 commit intov1.14.0.xfrom
sshende-catalogicsoftware wants to merge 1 commit intov1.14.0.xfrom
Conversation
- This fix addresses an issue where namespace labels and annotations were not being updated during a restore, even when overwrite behavior was expected. - Updated namespace restore logic to handle `ExistingResourcePolicyTypeUpdate` using the `processUpdateResourcePolicy` function. - Added fallback logic to manually update labels and annotations if the patch operation fails. - Ensured that namespace updates only occur when the `--existing-resource-policy` flag is set to `update`. - Cluster-scoped resources like Namespace are included even when specific namespaces are selected. - Update image tag name from v1.14.0.8 to v1.14.0.9. Fixes KUBEDR-6210
dzaninovic
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExistingResourcePolicyTypeUpdateusing theprocessUpdateResourcePolicyfunction.--existing-resource-policyflag is set toupdate.Fixes KUBEDR-6210