Skip to content

Conversation

@reednaa
Copy link
Member

@reednaa reednaa commented Mar 10, 2025

  • TODO: expose interface and validate signature

Goal:
Add support for an off-chain auction. That is an auction taking place on an order server where off-chain solvers bid. This PR does not define how the auction works. This can be defined in the future by setting the first byte of the fulfillment context.

Be warned:

  1. The fulfillment context is overloaded. The user provides it as bytes1(TYPE) | bytes32(signer) | ... but the solver provides it as uint256(trueAmount) | bytes1(TYPE) | bytes32(signer) | ...
  2. How trueAmount is derived is entirely up to the signer. It has to understand the type AND what the information after the signer means.
  3. Based on CoinFillerWithFee.
  4. Type 0x00 and 0x01 is not supported. It is expected that orders follow the structure above but it is not explicitly checked.

… TODO: expose interface and validate signature
@reednaa reednaa changed the title Add priliminary support for signed orders (off-chain auctions).… Add priliminary support for signed orders (off-chain auctions) Mar 10, 2025
@jsanmigimeno jsanmigimeno changed the title Add priliminary support for signed orders (off-chain auctions) Add preliminary support for signed orders (off-chain auctions) Mar 11, 2025
@reednaa
Copy link
Member Author

reednaa commented Mar 11, 2025

The OutputDescription.amount should specify a minimum.

@reednaa
Copy link
Member Author

reednaa commented Mar 11, 2025

Add an arbitrary 0x80 to the beginning of modified fulfillment context.

Add docs that means: 0x80 is 32 added bytes.

@reednaa reednaa marked this pull request as draft April 29, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants