fix: add patch for react-native-get-random-values#37
Open
bidah wants to merge 1 commit intocawfree:mainfrom
Open
fix: add patch for react-native-get-random-values#37bidah wants to merge 1 commit intocawfree:mainfrom
bidah wants to merge 1 commit intocawfree:mainfrom
Conversation
b292835 to
12839a2
Compare
|
can we merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bugfix
What is the current behavior? (You can also link to an open issue here)
When running generator it builds but upon running
yarn iosit breaks with error message related to duplicates.Ref: Duplicate interface definition for class 'RCTModuleRegistry' expo/expo#15649
What is the new behavior (if this is a feature change)?
It adds on the build pipeline a new function at the end that adds to the
patchesdirectory the needed patch to overwrite a header file inreact-native-get-random-valuesOther information:
--