Skip to content

Comments

fix: add patch for react-native-get-random-values#37

Open
bidah wants to merge 1 commit intocawfree:mainfrom
bidah:patch-react-nativereact-native-get-random-values
Open

fix: add patch for react-native-get-random-values#37
bidah wants to merge 1 commit intocawfree:mainfrom
bidah:patch-react-nativereact-native-get-random-values

Conversation

@bidah
Copy link

@bidah bidah commented Jun 7, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bugfix

  • What is the current behavior? (You can also link to an open issue here)
    When running generator it builds but upon running yarn ios it breaks with error message related to duplicates.
    Ref: Duplicate interface definition for class 'RCTModuleRegistry' expo/expo#15649

  • What is the new behavior (if this is a feature change)?
    It adds on the build pipeline a new function at the end that adds to the patches directory the needed patch to overwrite a header file in react-native-get-random-values

  • Other information:
    --

@bidah bidah force-pushed the patch-react-nativereact-native-get-random-values branch from b292835 to 12839a2 Compare June 7, 2022 19:48
@nel349
Copy link

nel349 commented Aug 11, 2022

can we merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants