Skip to content

Conversation

@stepancheg
Copy link
Contributor

No description provided.

@stepancheg stepancheg force-pushed the errno branch 5 times, most recently from d61accd to fe64d85 Compare January 16, 2026 05:29
@stepancheg stepancheg marked this pull request as ready for review January 16, 2026 06:28
@stepancheg stepancheg force-pushed the errno branch 3 times, most recently from 2593885 to db393fa Compare January 17, 2026 03:10
@cberner
Copy link
Owner

cberner commented Jan 17, 2026

@codex review

@chatgpt-codex-connector
Copy link

To use Codex here, create a Codex account and connect to github.

@cberner cberner requested a review from Copilot January 17, 2026 04:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors error handling by making Errno a public type and updating all ReplyXxx::error methods to accept Errno instead of c_int. This provides type safety and a clearer API for error handling across the codebase.

Changes:

  • Made Errno type public through src/lib.rs
  • Updated all ReplyXxx::error method signatures to accept Errno instead of c_int
  • Migrated all error handling code to use Errno constants instead of raw libc error codes
  • Added EFTYPE constant for FreeBSD/macOS platforms

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/reply.rs Updated all Reply type error methods to accept Errno instead of c_int, removed assertion check
src/ll/mod.rs Added EFTYPE errno constant and improved documentation for from_i32
src/lib.rs Exported Errno as public type, updated default implementations to use Errno constants
src/experimental.rs Updated Result type alias to use Errno instead of c_int
examples/simple.rs Migrated all error handling to use Errno type throughout the filesystem implementation
examples/poll.rs Replaced raw libc error constants with Errno type
examples/passthrough.rs Updated error handling to use Errno::ENOENT
examples/notify_inval_inode.rs Migrated error handling to Errno type
examples/notify_inval_entry.rs Updated error responses to use Errno type
examples/ioctl.rs Replaced libc error constants with Errno equivalents
examples/hello.rs Updated error handling to use Errno::ENOENT
examples/async_hello.rs Migrated async filesystem implementation to use Errno type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cberner cberner merged commit c6b9597 into cberner:master Jan 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants