imports_granularity=Item #491
Closed
+575
−284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepancheg
force-pushed
the
imports-granularity
branch
3 times, most recently
from
5aa685b to
e755b5f
Compare
stepancheg
force-pushed
the
imports-granularity
branch
from
e755b5f to
afbd42e
Compare
Merge conflicts are much easier to resolve when one import per line is used. Consider adopting unstable option imports_granularity=Item. rust-lang/rustfmt#4991
stepancheg
force-pushed
the
imports-granularity
branch
from
afbd42e to
3fd840e
Compare
Owner
|
Oh cool. Ya, this seems like a good setting. Too bad it's unstable, but I can live with that since it's just rustfmt |
Owner
|
Oops. Clicked the wrong button. This is now merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider adopting
imports_granularity=Itemnightly rustfmt option.Merge conflicts are much easier to resolve when one import per line is used. Consider adopting unstable option imports_granularity=Item.
rust-lang/rustfmt#4991
Although the option is unstable, some used for a long time mostly without problems. For example, Meta https://github.com/facebook/buck2/blob/main/rustfmt.toml