scss language addition#192
Open
FabioDiMonte wants to merge 14 commits intoccampbell:masterfrom
HotelsDotCom:feature/scss-language-addition
Open
scss language addition#192FabioDiMonte wants to merge 14 commits intoccampbell:masterfrom HotelsDotCom:feature/scss-language-addition
FabioDiMonte wants to merge 14 commits intoccampbell:masterfrom
HotelsDotCom:feature/scss-language-addition
Conversation
Author
|
some screenshots made using the code in this PR (including the changed CSS theme "solarized dark") base scss syntax (nesting, placeholders, mixins, ...)
loops, conditions, interpolations
lists and maps
|
js/language/scss.js
Outdated
|
|
||
| 'use strict'; | ||
|
|
||
| if(!Rainbow){ |
Owner
There was a problem hiding this comment.
Why would Rainbow not be included here? Also checking for it directly will actually trigger an error if it doesn't exist
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added SCSS syntax recognition, which includes:
$myVar)#{$myClass})@mixin,@function,@extend,@import,@include) and all their inner syntax@for,@eachand@while) along with their inner syntax