Pass user_data argument to free_cb_function registered with MPI_T_event_handle_free function#6
Open
kingshuk00 wants to merge 1 commit intocchambreau:topic/mpi_t_eventsfrom
Conversation
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 0827799: Pass user_data argument to free_cb_function regist...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
1 similar comment
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 0827799: Pass user_data argument to free_cb_function regist...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
…nt_handle_free function. Signed-off-by: Kingshuk Haldar <kingshuk.haldar@hlrs.de>
kingshuk00
force-pushed
the
mpi_t_events/user_data_freecb
branch
from
0827799 to
bc864bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit open-mpi@9350bee introduces the user-data argument in
MPI_T_event_handle_free()function. But it does not pass it along further while callingmca_base_event_registration_free(). Consequently,mca_base_event_registration_destructor()passes the registration->user_datamember directly making it not readily available in the callback. This commit should fix it.