Enhance pattern handling for more flexibility#63
Open
maddes-b wants to merge 4 commits intoccontavalli:masterfrom
Open
Enhance pattern handling for more flexibility#63maddes-b wants to merge 4 commits intoccontavalli:masterfrom
maddes-b wants to merge 4 commits intoccontavalli:masterfrom
Conversation
* Use pre-defined prefixes for debug and error messages to better distinguish log messages.
Allows to check combinations of values in different elements, e.g. git passes host and repository as separate parameters, useful for GitHub, GitLab, Bitbucket or similar. * Enhance docstring to reflect the enhancement and give GitHub example.
* Transform PATTERN_KEYS into a list to avoid an unmanageable single complex regex, instead split in several simple regex * Transform hard-coded public and private key determination into configurable pattern lists: PATTERN_PUBKEYS, PATTERN_PRIVKEYS * A second parameter after the regex can be used to define what part to remove for key pair matching * PATTERN_KEYS, PATTERN_PUBKEYS, PATTERN_PRIVKEYS new only search/test against filename, and nomore their full path * Compile regex for PATTERN_KEYS, PATTERN_PUBKEYS, PATTERN_PRIVKEYS, MATCH_PATH, MATCH_ARGV for better performance. This is done in a general way within Config.get() * Add some debug prints for analyzing pattern matching * Add debug print of found key pairs including hint if corresponding public or private key couldn't be found * Enhance docstring to reflect changes * Enhance docstring with more details to key pair handling and pattern matching * Enhance docstring with already present features of per-identity ssh config file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 698d94f (HEAD -> feature-more-flexible-matching, origin/feature-more-flexible-matching)
Author: maddes-b maddes-b@users.noreply.github.com
Date: Mon Jan 11 17:37:47 2021 +0000
commit 746d174
Author: maddes-b maddes-b@users.noreply.github.com
Date: Sun Jan 10 23:18:51 2021 +0000
commit b2a0e81
Author: maddes-b maddes-b@users.noreply.github.com
Date: Sun Jan 10 21:39:14 2021 +0000