Conversation
|
Looks reasonable to me. I usually use a slightly different setup including testpypi as an error check such as in this example: https://github.com/ccpem/empiarreader/blob/main/.github/workflows/python-publish.yml, but this looks like it should work. Looks like will only know for sure when a new release is created. |
|
I was assigned to the MR but not as a reviewer. So I have added myself as a reviewer and approved. I'll leave it to you @jmp1985 to do the actual merge and create a release and check the pypi release it updated. Are you happy to maintain the pypi release going forward? If you need to hand it off to ccpem then we'll need to be added as owners of the profet pypi project. |
|
@JatGreer I am happy to add ccpem as an owner of the profet repo. What is the username on Pypi? |
This should update workflows to allow the package to be published to Pypi