Skip to content

Hotfix for get_xhtml_errors operation #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ASL-rmarshall merged 2 commits into from
Nov 17, 2025
Merged

Hotfix for get_xhtml_errors operation #1436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a40c8d
Remove value.strip
ASL-rmarshall Nov 13, 2025
8264532
Add test for null value
ASL-rmarshall Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cdisc_rules_engine/operations/get_xhtml_errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ def _execute_operation(self):
return dataset[target].apply(self._ensure_dataset_is_valid_xhtml)

def _ensure_dataset_is_valid_xhtml(self, value: str) -> list[str]:
value: str = value.strip()
if not value:
return []

Expand Down
10 changes: 10 additions & 0 deletions tests/unit/test_operations/test_get_xhtml_errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,16 @@
"invalid-namespace",
SchemaNotFoundError,
),
( # null value
"target",
PandasDataset.from_records(
[
{"target": None}, # noqa: E501
]
),
"http://www.cdisc.org/ns/usdm/xhtml/v1.0",
[[]],
),
],
)
def test_get_xhtml_errors(
Expand Down
Loading