#1194 Add domain suffix extraction and standard domains operation for domain validation#1439
Merged
gerrycampion merged 15 commits intomainfrom Dec 3, 2025
Merged
Conversation
… DOMAIN substring comparison
RakeshBobba03
changed the title
gerrycampion
requested changes
Nov 24, 2025
Collaborator
|
Also, can you provide a sample rule and test data to completely test CG0663. You can attach to this PR. (it will also help with your demo) |
Collaborator
Author
Here are the dataset files and Rule file I used for testing: local-rule.yaml |
…in DatasetMetadataDefineDatasetBuilder._get_dataset_dataframe()
gerrycampion
requested changes
Nov 25, 2025
…and remove redundant extract_metadata code
…AP domain test cases
gerrycampion
requested changes
Nov 26, 2025
gerrycampion
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the ability to extract domain suffixes from AP-related domain names and compare them against valid SDTM domains. This adds a
domain_suffixoption to theextract_metadataoperation that extracts characters 3-4 from domain names (e.g., "FA" from "APFA"), and introduces a newstandard_domainsoperation that returns a sorted list of valid SDTM domain names from the CDISC Library metadata. These changes enable rule CG0663 to validate that Associated Persons (AP) Core Domains have a 4-character length beginning with 'AP' and ending with a valid 2-character SDTM domain.