Skip to content

hotfix20251216: #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EfrosIonelu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

hotfix20251216: #1488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cdisc_rules_engine/services/data_services/usdm_data_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,12 @@ def __get_datasets_content_index(self, dataset_name: str, json) -> List[dict]:
dataset_dict = {}
for path in metadata:
entity = path["entity"]

Copy link
Collaborator

@SFJohnson24 SFJohnson24 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seem null/none entities are meant to go through to the codeblock on 467 per the comment on 466. Could this be resolved simply by changing line 464 to if entity and entity.lower() == "code": ?

Copy link
Author

@EfrosIonelu EfrosIonelu Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can make this change if there will be no errors after

if entity is None:
raise ValueError(
f"Invalid metadata: 'entity' is null for path '{path.get('path')}'"
)

if entity.lower() == "code":
entity = "Code"
# Do not skip 'null' entities; include them as datasets
Expand Down
Loading