Add define_dataset_variable_order with OrderNumber sorting support (#791)#1508
Merged
gerrycampion merged 45 commits intomainfrom Mar 5, 2026
Merged
Add define_dataset_variable_order with OrderNumber sorting support (#791)#1508gerrycampion merged 45 commits intomainfrom
gerrycampion merged 45 commits intomainfrom
Conversation
…neXMLReaderFactory
…org/cdisc-rules-engine into 791-define-variable-order
gerrycampion
requested changes
Feb 19, 2026
cdisc_rules_engine/dataset_builders/dataset_metadata_define_dataset_builder.py
Show resolved
Hide resolved
cdisc_rules_engine/dataset_builders/dataset_metadata_define_dataset_builder.py
Outdated
Show resolved
Hide resolved
… and document define_dataset_variable_order in Rule_Type.md
gerrycampion
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#791 Implements
define_dataset_variable_ordermetadata variable that returns dataset variables ordered by OrderNumber when present in Define XML, otherwise falls back to XML document order. This adds the new field toextract_dataset_metadata()andextract_domain_metadata()methods in BaseDefineXMLReader, updates all relevant dataset builders to include the field in their output, adds schema validation in MetaVariables.json, and includes comprehensive unit tests. The sorting logic is centralized in_get_ordered_dataset_variables()method following DRY principles.