Merged
Conversation
RamilCDISC
reviewed
Jan 26, 2026
| } | ||
|
|
||
| def get_conformance_details_data( | ||
| def get_conformance_details_data( # noqa |
Collaborator
There was a problem hiding this comment.
Could you please mention the reason for skipping the lint check here now?
Collaborator
Author
There was a problem hiding this comment.
ignoring complexity check to keep the conformance detail data as one function--it is not complex, it just needs to fill in each field of the conformance details
| ) | ||
| @click.pass_context | ||
| def validate( | ||
| def validate( # noqa |
Collaborator
Author
There was a problem hiding this comment.
same as above--I wanted to keep validate as a single functional unit
RamilCDISC
approved these changes
Jan 30, 2026
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR updates the use case processing for TIG. Instead of hardcoded use case now comes from the dataset. The PR was validated by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR logic in accordance with AC.
- Ensuring all unit and regression testing pass.
- Ensuring relevant testing is updated.
- Ensuring relevant documentation is updated.
- Ensuring execution for editor and cli is not affected.
- Running manual validation using a rule in local editor.
- Running manual validation using a rule in CLI.
- Ensuring case when use case matching to rule is mentioned in dataset.
- Case when use case in dataset is different than the rule.
- Case when use case is missing.
- Case when there are multiple use cases in dataset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR along with the editor PR adds -use-case to scope rules for TIG. This allows the custom domains to be ruled as in scope and have the rule fire for them.
This resolves the issue with the custom domains running for TIG0514 from the original ticket.
Note: the YP class is out of scope so that rule will not fire but the two X- domains will