Skip to content

#1348 fix not as head condition provides proper AST#1574

Merged
SFJohnson24 merged 8 commits intomainfrom
1348-fix-first-rule-not-condition
Feb 2, 2026
Merged

#1348 fix not as head condition provides proper AST#1574
SFJohnson24 merged 8 commits intomainfrom
1348-fix-first-rule-not-condition

Conversation

@alexfurmenkov
Copy link
Collaborator

No description provided.

@alexfurmenkov alexfurmenkov marked this pull request as ready for review January 29, 2026 16:02
Copy link
Collaborator

@SFJohnson24 SFJohnson24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR correctly resolves the issue where empty condition composites are returned when NOT conditions are the sole condition. Rule and both datasets from original ticket now execute correctly with the Not rule and no longer require the all conditon

@SFJohnson24 SFJohnson24 merged commit 08d53f1 into main Feb 2, 2026
11 checks passed
@SFJohnson24 SFJohnson24 deleted the 1348-fix-first-rule-not-condition branch February 2, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect results with "not" as first Check condition

3 participants