Merged
Conversation
SFJohnson24
requested review from
RamilCDISC and
gerrycampion
and removed request for
gerrycampion
RamilCDISC
approved these changes
Feb 3, 2026
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR adds two datasets to resource folder so user can run a a test on release. The readme documentation is updated and specifies clearly steps for running the test validation on 3 different platforms: linux, mac and windows. This fulfills the AC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the function description (for --help) and readme for test-validate so end-users can understand how to run it
it also moves the two test datasets as these are not bundled with the release so that end-users can run this command with the executable.