Skip to content

Update core.py#1607

Merged
SFJohnson24 merged 5 commits intomainfrom
SFJohnson24-patch-3
Feb 12, 2026
Merged

Update core.py#1607
SFJohnson24 merged 5 commits intomainfrom
SFJohnson24-patch-3

Conversation

@SFJohnson24
Copy link
Collaborator

@SFJohnson24 SFJohnson24 commented Feb 10, 2026

this PR normalizes standard before it is ingested by engine via validation_args. This causes downstream issues where the standard is not identified.

Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR updates the core to normalize the specified standard before processing it. This ensures correct library metadata is fetched. The validation was done by:

  1. Reviewing the PR in accordance with AC.
  2. Ensuring all unit and regression testing pass.
  3. Running manual validation using CLI with upper and lower case standard name.
  4. Running validation using dev rule editor.
  5. Ensuring results in both match.

@mhungria
Copy link

I recommend to adjust the core engine treatment of standard as it is defined in CT for Define-XML, Standard Name (case sensitive); i.e., the user should refer to SDTMIG, ADaMIG, etc. (see https://library.cdisc.org/browser/#/mdr/ct/2025-09-26/packages/define-xmlct-2025-09-26/codelists/C170452).

The core engine could provide a message to the users indicating that the standard indicated is not available in CT for any variations of case not in CT.

Note: As CDISC Standard developers and part of CDISC Standards implementation teams, we need to work on better integration across standards and systems.

@SFJohnson24 SFJohnson24 merged commit 2a9a410 into main Feb 12, 2026
11 checks passed
@SFJohnson24 SFJohnson24 deleted the SFJohnson24-patch-3 branch February 12, 2026 16:05
@eljanssens
Copy link
Collaborator

@mhungria since this is a CLI and not a CDISC standard, we are not going to enforce people to add CDISC CT correct commands. This will be challenging with for example ADaMIG. The engine will now handle the standards case insensitive which should solve your problem. As long as the standard wording is correct, the engine will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Difference skipped vs success between CLI and rule editor? - ref CORE-000711 / published rule

4 participants