#1267 changed full path to original path in stdm reporting#1618
#1267 changed full path to original path in stdm reporting#1618SFJohnson24 merged 5 commits intomainfrom
Conversation
| "label": dataset.label, | ||
| "path": str(Path(dataset.full_path or "").parent), | ||
| "path": str( | ||
| Path(dataset.original_path or dataset.full_path or "").parent |
There was a problem hiding this comment.
I think our intent is to always show the original path and not the parquet file path ever. So it should be dataset.original_path or "" only. @SFJohnson24 Could you please confirm which one you prefer?
There was a problem hiding this comment.
@RamilCDISC yes we are not trying to show the path to the parquet files in the reporting, we want the original path from the submitted data
There was a problem hiding this comment.
@alexfurmenkov @SFJohnson24 @RamilCDISC
EDIT
I think I partially resolved this issue for the issue reporting tabs:
https://github.com/cdisc-org/cdisc-rules-engine/pull/1551/changes#diff-61bbdda116cb3d9e8bce503b115f0c16fe154902e296785925d922821eae917b
I don't think I fixed the datasets tabs. I agree with Ramil and Sam.
There was a problem hiding this comment.
Hi, @RamilCDISC, updated code as discussed.
Had to change dataset metadata in test_get_export so it will contain original_path.
There was a problem hiding this comment.
UPD: we should keep dataset.original_path or dataset.full_path or "" since dataset.original_path is only filled when we have large_dataset_validation
RamilCDISC
left a comment
There was a problem hiding this comment.
I ran validations locally setting the DATASET_SIZE_THRESHOLD=0 in .env, the following reports still show path "/var/folders/7t/g8jmyzxn6k797cg9xt0sd9z40000gn/T" One report was generated using xpt and the other user excel file as dataset.
|
Hi, @RamilCDISC, can you please share you run configuration?
contains proper path. |
|
@alexfurmenkov I am running validation on a mac. In my .env I have set For xpt dataset location is shows as i have pulled the latest changes from the branch. |
|
@RamilCDISC , I've tried your configuration on mac
and got next report: CORE-Report-2026-02-27T15-29-52.xlsx can you please contact me in slack so we can find a root of this issue on your machine? |
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR updates the reporting to report correct path for dataset and not parquet files path. The validation was done by ensuring test updates and all test passing. Manual testing was run by generating reports using Dask implementation with xpt, xlsx, json an ndjson datasets.
No description provided.