Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
8807f61
Add define_dataset_variable_order with OrderNumber sorting support (#…
RakeshBobba03 Jan 2, 2026
628757d
Fix test_validate_dataset_metadata_against_define_xml by mocking Defi…
RakeshBobba03 Jan 2, 2026
a1d9a3e
Merge branch 'main' into 791-define-variable-order
RakeshBobba03 Jan 6, 2026
a45e1a3
Update test_extract_dataset_metadata to include define_dataset_variab…
RakeshBobba03 Jan 6, 2026
ada1287
Merge branch 'main' into 791-define-variable-order
RamilCDISC Jan 6, 2026
93b3e90
Merge branch 'main' into 791-define-variable-order
RakeshBobba03 Jan 9, 2026
8a6a6d9
Merge branch '791-define-variable-order' of https://github.com/cdisc-…
RakeshBobba03 Jan 9, 2026
f26d614
Auto-updated branch with latest changes from main
SFJohnson24 Jan 12, 2026
c6da795
Auto-updated branch with latest changes from main
SFJohnson24 Jan 12, 2026
859d610
Auto-updated branch with latest changes from main
SFJohnson24 Jan 12, 2026
4ea71f0
Merge branch 'main' into 791-define-variable-order
RakeshBobba03 Jan 12, 2026
13c43f7
Merge branch '791-define-variable-order' of https://github.com/cdisc-…
RakeshBobba03 Jan 12, 2026
be11222
Auto-updated branch with latest changes from main
SFJohnson24 Jan 12, 2026
987d9be
Auto-updated branch with latest changes from main
SFJohnson24 Jan 12, 2026
b945085
Auto-updated branch with latest changes from main
SFJohnson24 Jan 12, 2026
f62e4db
Auto-updated branch with latest changes from main
SFJohnson24 Jan 12, 2026
900b0f1
Auto-updated branch with latest changes from main
SFJohnson24 Jan 13, 2026
154b636
Auto-updated branch with latest changes from main
SFJohnson24 Jan 13, 2026
2ddb716
Auto-updated branch with latest changes from main
SFJohnson24 Jan 13, 2026
269b13c
Auto-updated branch with latest changes from main
SFJohnson24 Jan 14, 2026
c508435
Auto-updated branch with latest changes from main
SFJohnson24 Jan 16, 2026
45e5eef
Auto-updated branch with latest changes from main
SFJohnson24 Jan 19, 2026
48d5da7
Auto-updated branch with latest changes from main
SFJohnson24 Jan 20, 2026
eeb6ff1
Auto-updated branch with latest changes from main
SFJohnson24 Jan 22, 2026
6485272
Auto-updated branch with latest changes from main
SFJohnson24 Jan 26, 2026
0d95692
Auto-updated branch with latest changes from main
SFJohnson24 Jan 26, 2026
17eb51b
Auto-updated branch with latest changes from main
SFJohnson24 Jan 27, 2026
db88366
Auto-updated branch with latest changes from main
SFJohnson24 Jan 27, 2026
94a0241
Auto-updated branch with latest changes from main
SFJohnson24 Jan 28, 2026
e8b5790
Auto-updated branch with latest changes from main
SFJohnson24 Jan 28, 2026
16470e3
Auto-updated branch with latest changes from main
SFJohnson24 Jan 30, 2026
6e748f1
Auto-updated branch with latest changes from main
SFJohnson24 Jan 30, 2026
f477744
Auto-updated branch with latest changes from main
SFJohnson24 Jan 30, 2026
dd3a48c
Auto-updated branch with latest changes from main
SFJohnson24 Jan 30, 2026
722f0b8
Auto-updated branch with latest changes from main
SFJohnson24 Feb 1, 2026
f87b2f3
Auto-updated branch with latest changes from main
SFJohnson24 Feb 2, 2026
6626ca4
Merge branch 'main' into 791-define-variable-order
RakeshBobba03 Feb 11, 2026
bdd7466
Merge branch '791-define-variable-order' of https://github.com/cdisc-…
RakeshBobba03 Feb 11, 2026
57d4241
Merge branch 'main' into 791-define-variable-order
RakeshBobba03 Feb 16, 2026
ad980de
Merge branch 'main' into 791-define-variable-order
RakeshBobba03 Feb 17, 2026
fd3647e
converted issue templates to forms
gerrycampion Feb 19, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 115 additions & 0 deletions .github/ISSUE_TEMPLATE/1-bug.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
name: Bug Report
description: An unexpected problem or behavior
projects:
- cdisc-org/19
type: Bug
body:
- type: dropdown
id: standard
validations:
required: true
attributes:
label: Standard
multiple: true
options:
- CDISC ADaM
- CDISC Define-XML
- CDISC SDTM/SDTMIG
- CDISC SEND
- CDISC USDM
- FDA BR SDTM
- FDA BR SDTMIG
- FDA BR SEND
- FDA VR SDTMIG
- FDA VR SENDIG
- Custom
- type: input
id: reference_rule_id
validations:
required: true
attributes:
label: Reference Rule ID(s)
- type: input
id: core_id
attributes:
label: Conformance Rule ID(s) (if published in CORE)
value: CORE-
- type: input
id: jira
attributes:
label: JIRA Ticket
value: https://jira.cdisc.org/projects/CORERULES/issues/CORERULES-
- type: markdown
attributes:
value: "In the next fields, please provide a [Minimal Reproducible Example](https://stackoverflow.com/help/minimal-reproducible-example)."
- type: textarea
id: rule
validations:
required: true
attributes:
label: Rule YAML
render: YAML
value: |
Authorities:
- Organization:
Standards:
- Name:
References:
- Citations:
- Cited Guidance:
Document:
Item:
Section:
Origin:
Rule Identifier:
Id:
Version:
Version:
Version:
Check:
all:
- name:
operator:
value:
Core:
Id:
Status:
Version: '1'
Description:
Executability: Fully Executable
Match Datasets:
- Keys:
-
Name:
Operations:
- id:
operator:
Outcome:
Message:
Output Variables:
-
Rule Type:
Scope:
Sensitivity:
- type: textarea
id: test_data
validations:
required: true
attributes:
label: Sample Test Data File
- type: textarea
id: output
validations:
required: true
attributes:
label: Output report and/or log file
- type: textarea
id: expected
validations:
required: true
attributes:
label: Expected output
- type: textarea
id: additional_info
attributes:
label: Any Additional Information
109 changes: 109 additions & 0 deletions .github/ISSUE_TEMPLATE/2-feature.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
name: Rule-related Feature Request
description: A request for a new feature or enhancement related to a rule
projects:
- cdisc-org/19
type: Feature
body:
- type: dropdown
id: standard
validations:
required: true
attributes:
label: Standard
multiple: true
options:
- CDISC ADaM
- CDISC Define-XML
- CDISC SDTM/SDTMIG
- CDISC SEND
- CDISC USDM
- FDA BR SDTM
- FDA BR SDTMIG
- FDA BR SEND
- FDA VR SDTMIG
- FDA VR SENDIG
- Custom
- type: input
id: reference_rule_id
validations:
required: true
attributes:
label: Reference Rule ID(s)
- type: input
id: core_id
attributes:
label: Conformance Rule ID(s) (if published in CORE)
value: CORE-
- type: input
id: jira
attributes:
label: JIRA Ticket
value: https://jira.cdisc.org/projects/CORERULES/issues/CORERULES-
- type: markdown
attributes:
value: "In the next fields, please provide a [Minimal Reproducible Example](https://stackoverflow.com/help/minimal-reproducible-example)."
- type: textarea
id: rule
validations:
required: true
attributes:
label: Proposed Rule YAML
render: YAML
value: |
Authorities:
- Organization:
Standards:
- Name:
References:
- Citations:
- Cited Guidance:
Document:
Item:
Section:
Origin:
Rule Identifier:
Id:
Version:
Version:
Version:
Check:
all:
- name:
operator:
value:
Core:
Id:
Status:
Version: '1'
Description:
Executability: Fully Executable
Match Datasets:
- Keys:
-
Name:
Operations:
- id:
operator:
Outcome:
Message:
Output Variables:
-
Rule Type:
Scope:
Sensitivity:
- type: textarea
id: test_data
validations:
required: true
attributes:
label: Attach any sample test data file(s)
- type: textarea
id: expected
validations:
required: true
attributes:
label: Expected output
- type: textarea
id: additional_info
attributes:
label: Any Additional Information
4 changes: 4 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
contact_links:
- name: CORE Discussion Forum
url: https://github.com/cdisc-org/cdisc-rules-engine/discussions/categories/general
about: Please ask and answer general questions here.
35 changes: 0 additions & 35 deletions .github/ISSUE_TEMPLATE/rule-blocking-bug.md

This file was deleted.

35 changes: 0 additions & 35 deletions .github/ISSUE_TEMPLATE/rule-blocking-enhancement.md

This file was deleted.

6 changes: 4 additions & 2 deletions cdisc_rules_engine/dataset_builders/base_dataset_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,17 +109,18 @@ def get_dataset_contents(self, **kwargs):

def get_define_xml_item_group_metadata_for_dataset(
self, dataset_metadata: SDTMDatasetMetadata
) -> List[dict]:
) -> dict:
"""
Gets Define XML item group metadata
returns a list of dictionaries containing the following keys:
returns a dictionary containing the following keys:
"define_dataset_name"
"define_dataset_label"
"define_dataset_location"
"define_dataset_class"
"define_dataset_structure"
"define_dataset_is_non_standard"
"define_dataset_variables"
"define_dataset_variable_order"
"define_dataset_key_sequence"
"define_dataset_has_no_data"
"""
Expand All @@ -142,6 +143,7 @@ def get_define_xml_item_group_metadata_for_domain(self, domain: str) -> List[dic
"define_dataset_structure"
"define_dataset_is_non_standard"
"define_dataset_variables"
"define_dataset_variable_order"
"define_dataset_key_sequence"
"define_dataset_has_no_data"
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def build(self):
define_dataset_name - dataset name from define_xml
define_dataset_structure - dataset structure
define_dataset_variables - list of variables in the dataset
define_dataset_variable_order - ordered list of variables in the dataset

...,
"""
Expand Down
Loading
Loading