Conversation
…e-evaluation-errors-that-appear-in-the-logs
…dataset confusion
…differing datatypes
| dataset = self.data_service.get_dataset(dataset_meta.filename) | ||
| referenced_datasets[dataset_meta.name] = dataset | ||
| for dataset_metadata in self.data_service.get_datasets(): | ||
| dataset = self.data_service.get_dataset(dataset_metadata.name) |
There was a problem hiding this comment.
I believe this needs to stay as
dataset = self.data_service.get_dataset(dataset_meta.filename)
Looking at the interface--i think it is another case of name and filename getting mixed. It needs the file extension, otherwise it returns an empty dataframe. I tested this on cg0370 and was not getting the correct result as it was not finding the LB dataset referenced in the CO dataset (was returning nothing for the distinct operation)
we should change all the get_datasets parameters in the interface and excel/dummy/local/usdm data services to dataset_path to avoid this
There was a problem hiding this comment.
Nice changes to resolve several issues, organize code, and use native functionality/metadata properties over unneeded functions.
PR preserves relrec merge functionality--tested cg0602
Correctly resolves execution error vs. skip status from parent issue
Only found one issue that needs to be addressed. Please see comment
…e-evaluation-errors-that-appear-in-the-logs
To compare the Execution Errors before and after, see these reports:
Report before
Report after
CORE Test Suite Updates