Merged
Conversation
Closed
RamilCDISC
approved these changes
Mar 13, 2026
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR updates the excel and json dataset readers to handle whitespaces in headers. The updated code was validated by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR in accordance with AC.
- Ensuring all unit and regression testing pass.
- Ensuring relevant testing is updated.
- Verifying the cases covered in new tests.
- The passing of test using the white spaces json and excel file validates the PR.
gerrycampion
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent issues like the one experienced in the attached issue, I added logic to strip column headers of their whitespace. Since we glean so much metadata--from column prefixes to domain from correctly IDing these columns, removing whitespace from them when reading the files is important
this was added to xlsx and json readers. since xpt are made with tooling, padded column names are not a concern. NDJSON and Dataset-JSON readers are also unaffected as their column names are derived from schema-validated "name" fields rather than raw file headers.