- changed definitions to global and \let to \edef so \lastframenumber…#8
- changed definitions to global and \let to \edef so \lastframenumber…#8ferdinandyb wants to merge 1 commit intocebe:masterfrom
Conversation
… behaves correctly inside frames, with overlays and also outside of frames (i.e. that only one header is actually written per frame in all situations) - changed \newcommand to \newcommand<> to be overlay-aware, and passed overlay to \note - added an optional parameter to newcommand and passed it to \note to preserve \note[item] behaviour - added an \only<1> overlay to the actual writing of the notes to file, so even with overlay around, the notes are only written once to file
|
Thanks! Will try to find some time to review it soon. |
|
Have you had time to check it? |
|
Consider its inclusion. |
| % write note to file | ||
| \immediate\write\pdfpcnotesfile{\unexpanded{#1}}% | ||
| % inside frame there's no point doing it twice if there's an overlay | ||
| \only<1>{\immediate\write\pdfpcnotesfile{\unexpanded{#2}}}% |
There was a problem hiding this comment.
Hi, sorry for the long delay. I finally found some time to check this pull request. I tested it with some of my old slides and found that this line breaks notes that are placed on slides that are repeated with \againframe{}. Notes only show up on the first slide and are then not displayed on further usages of that slide.
There was a problem hiding this comment.
Jesus time flies, but I saw the surge in interest and seems I have a little time on my hands:) Do you think it would be possible to make a few simple set of slides as a benchmark slides, so we can check what not to break?
There was a problem hiding this comment.
Is the demo code in #16 an appropriate test case?
There was a problem hiding this comment.
I have created a tests folder and set up travis-ci tests to run them automatically. Will add more tests to verify current behavior.
4 participants
I hope I'm doing this right :)
… behaves correctly inside frames, with overlays and also outside of frames (i.e. that only one header is actually written per frame in all situations)
fixes #7