Add check-files command #55
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking NCAS files requires a call to GitHub for the latest instrument data. When checking a lot of files at once, this created a lot of calls to GitHub at once, a lot of which GitHub would reject, resulting in checksit errors. This PR address this by reducing the number of requests to GitHub needed when checking lots of files:
cvsmodule with the vocab checks (e.g.checksit.generic) were refreshing their vocab cache for each spec check. This has been changed to only import modules if not previously imported, allowing the vocab cache to persist across multiple spec checks.check-fileshas been added. This is functionally identical to thecheckCLI command, except that it takes a number of files as an argument and runs checksit on each. Doing this, rather than runningcheckon each file sequentially, allows the vocab cache to persist from one file to the next.