-
Notifications
You must be signed in to change notification settings - Fork 14
chore(structure): Remove remnants of VSCode ext #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cedarjs canceled.
|
Greptile SummaryThis PR removes legacy VSCode extension code from the Major changes:
Impact assessment:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant PR as This PR
participant Pkg as @cedarjs/structure
participant CLI as @cedarjs/cli
Note over PR: Remove VSCode Extension Code
PR->>Pkg: Delete language_server/ directory
Note right of Pkg: RWLanguageServer.ts (181 lines)<br/>commands.ts, diagnostics.ts, etc.
PR->>Pkg: Delete interactive_cli/ directory
Note right of Pkg: command_builder.ts (241 lines)<br/>UI components for extension
PR->>Pkg: Delete outline/ directory
Note right of Pkg: outline.ts (307 lines)<br/>Tree view generation
PR->>Pkg: Delete src/x/vscode.ts
Note right of Pkg: VSCode API wrappers<br/>showQuickPick, createTerminal
PR->>Pkg: Rename ide.ts → nodes.ts
Note right of Pkg: Remove IDE interfaces<br/>Keep core BaseNode/FileNode
PR->>Pkg: Rename vscode-languageserver-types.ts → diagnostics.ts
Note right of Pkg: Remove LSP imports<br/>Keep diagnostic utilities
PR->>Pkg: Update package.json
Note right of Pkg: Remove vscode-languageserver<br/>vscode-languageserver-textdocument<br/>@types/vscode
PR->>Pkg: Update model files
Note right of Pkg: Remove ideInfo() methods<br/>Update imports to new module names
CLI->>Pkg: Import printDiagnostics()
Note left of CLI: Public API unchanged<br/>CLI commands still work
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t test --minWorkers=1 --maxWorkers=4 |
✅ Succeeded | 2m 2s | View ↗ |
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 25s | View ↗ |
nx run-many -t build |
✅ Succeeded | 1m 20s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 9s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-01-01 22:54:42 UTC

Redwood at one point had a VSCode extension, it was a long time ago since it was maintained. This PR removes the code that we had in the framework for this extension that was only used by the extension. There is still code left that smells very much like extension code, but it'll take a bit more work to remove/rewrite, so I'll leave it in here for now