Skip to content

Conversation

@renaynay
Copy link
Member

Fixes an issue where we would discard all headers in case one failed. Now we can at least return the ones we synced successfully (as long as they're contiguous from from) so we don't need to do duplicate work.

@renaynay renaynay self-assigned this Dec 12, 2025
@renaynay renaynay added area:core_and_app Relationship with Core node and Celestia-App kind:fix Attached to bug-fixing PRs labels Dec 12, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 36.00%. Comparing base (2469e7a) to head (4b30d03).
⚠️ Report is 633 commits behind head on main.

Files with missing lines Patch % Lines
core/exchange.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4738      +/-   ##
==========================================
- Coverage   44.83%   36.00%   -8.83%     
==========================================
  Files         265      307      +42     
  Lines       14620    20777    +6157     
==========================================
+ Hits         6555     7481     +926     
- Misses       7313    12326    +5013     
- Partials      752      970     +218     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core_and_app Relationship with Core node and Celestia-App kind:fix Attached to bug-fixing PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants