Generator profile: fix computeComputedConstants()'s signature#1364
Merged
hsorby merged 4 commits intocellml:mainfrom Mar 2, 2026
Merged
Generator profile: fix computeComputedConstants()'s signature#1364hsorby merged 4 commits intocellml:mainfrom
computeComputedConstants()'s signature#1364hsorby merged 4 commits intocellml:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Generator profile so the generated computeComputedConstants() method has the correct (post-refactor) signature, and refreshes generated test resources/fixtures accordingly (Fixes #1363).
Changes:
- Update C generator profile
computeComputedConstants()interface/implementation strings to includedouble voiand rename the algebraic array parameter toalgebraicVariables. - Update Python generator profile
compute_computed_constants()signature to includevoiand usealgebraic_variables. - Regenerate/refresh test resources and update generator profile version strings + recorded profile SHA1s.
Reviewed changes
Copilot reviewed 233 out of 244 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/generatorprofile.cpp |
Updates default generator profile strings (C + Python) for computeComputedConstants() / compute_computed_constants() signatures and bumps default generated version strings. |
src/generatorprofilesha1values.h |
Updates generated SHA1s for the generator profiles to match the new profile content. |
tests/generator/generatorprofile.cpp |
Updates C++ unit test expectations for the new method signatures and version string. |
tests/bindings/python/test_generator_profile.py |
Updates Python binding tests to expect the updated C method signatures and version string. |
tests/resources/** |
Updates generated fixtures (C headers/implementations, Python models, and .out files) to match the new computeComputedConstants() signature and updated version strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hsorby
previously approved these changes
Mar 2, 2026
nickerso
reviewed
Mar 2, 2026
nickerso
previously approved these changes
Mar 2, 2026
Contributor
nickerso
left a comment
nickerso
left a comment
There was a problem hiding this comment.
The actual change seems ok, just left a comment on the .gitignore change...
… tests. Needed as otherwise we (now!?) get various messages that read: ENOENT: no such file or directory, open 'node:fs'
…FO` and `EXTERNAL_INFO` to `EXTERNAL_VARIABLE_INFO`.
nickerso
previously approved these changes
Mar 2, 2026
nickerso
approved these changes
Mar 2, 2026
hsorby
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1363.