This repository was archived by the owner on Jan 30, 2019. It is now read-only.
Allow a mix of keyword and string keys in :query#31
Open
ryfow wants to merge 1 commit intocemerick:masterfrom
Open
Allow a mix of keyword and string keys in :query#31ryfow wants to merge 1 commit intocemerick:masterfrom
ryfow wants to merge 1 commit intocemerick:masterfrom
Conversation
url/parse returns a query-map of strings to strings and the README provides examples of associng keyword keys into the query map. Using these features in combination caused the sort in map->query to blow up with a ClassCastException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
url/parse returns a query-map of strings to strings and the
README provides examples of associng keyword keys into the
query map. Using these features in combination caused
the sort in map->query to blow up with a ClassCastException.