Merged
Conversation
exkson
force-pushed
the
gsoc-2/implements-logs
branch
from
2fd5e62 to
2545620
Compare
Collaborator
Author
|
Hello @VallariAg @zmc @amathuria here is my proposal for logs command implementation on ceph-devstack. Looking forward to your feedback. |
zmc
reviewed
Apr 16, 2025
Member
zmc
left a comment
zmc
left a comment
There was a problem hiding this comment.
Thank you for your submission! I like your approach overall. Aside from the specific comments I've made, I'd also like to point out the pathlib library that we use elsewhere in the project; it's quite an improvement over working with os.path!
exkson
force-pushed
the
gsoc-2/implements-logs
branch
from
2545620 to
1474b7b
Compare
Collaborator
Author
|
Hello @zmc, I've applied the suggestions. I’d appreciate your feedback when you have a moment. Thanks! |
zmc
reviewed
Apr 23, 2025
Member
zmc
left a comment
zmc
left a comment
There was a problem hiding this comment.
Thanks for updating based on my feedback - these are good changes :)
kamoltat
approved these changes
Sep 8, 2025
Member
kamoltat
left a comment
kamoltat
left a comment
There was a problem hiding this comment.
Approved based on Zack's previous comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
logscommand for ceph-devstackFeatures