Conversation
Member
dmick
commented
Apr 21, 2025
dmick
commented
- the publish*message functions and callers
- the Bus controller
- tests and fixtures for the above
- the pika dependency
Member
Author
|
I want to actually deploy this and make sure it's ok, but wouldn't mind a checkover anyway while I do that. |
- the publish*message functions and callers - the Bus controller - tests and fixtures for the above - the pika dependency Signed-off-by: Dan Mick <dan.mick@redhat.com>
zmc
approved these changes
Apr 22, 2025
Member
zmc
left a comment
zmc
left a comment
There was a problem hiding this comment.
This all looks good to me. Clearly nothing major is missing or else we'd have failing tests
Member
Author
|
I decided it was safe enough to pip install from the branch. Service is running as expected. Watching tshark for amqp from 1.shaman, seeing none. I am seeing probing connections from unknown IPs. One more entry path to close out, yay! merging. I will disable rabbitmq on shaman.ceph.com as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.