Conversation
VallariAg
force-pushed
the
docker-dev-setup
branch
from
074d4c0 to
6708201
Compare
kamoltat
reviewed
Oct 18, 2023
Member
kamoltat
left a comment
kamoltat
left a comment
There was a problem hiding this comment.
Just a little comment, also can you please include a more descriptive PR description? Maybe like the purpose of this feature and what it will enable teuthology-api to do
src/routes/presets.py
Outdated
| detail="You need to be logged in", | ||
| headers={"WWW-Authenticate": "Bearer"}, | ||
| ) | ||
| db_preset = PresetsService(db).get_by_username_and_name( |
Member
There was a problem hiding this comment.
maybe add a comment saying checking for existing presets or change the variable name to something db_preset_exists
using postgres database 'tapi_db' Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
creates the following: models/presets.py: create_preset, get_user_presets, get_preset routes/presets.py: GET /, GET list/, POST /add schemas/presets.py: PresetSchema Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
models/presets: add get_preset_id, update_preset, delete_preset and PresetsDatabaseException Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Member
Author
|
@Devansh3712 I think you can work on top of this branch. There are few things I remember that needed to be addressed since I last updated it:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presets allow users to save teuthology-suite
command config with a unique name for that user
to be reused again.
This PR:
PresetsDatabaseException