Auth service tests

[dikwickley]

This PR aims to add tests for the auth service. WIP for #5

• Separate out auth service layer from Routes
• Write test cases for auth service

[dikwickley]

@VallariAg I have separated out the service layer in /login route.
Now the GH login part can be mocked easily by replacing the AuthServiceGH with AuthServiceMock during testing.
We can use this to replace it: https://fastapi.tiangolo.com/advanced/testing-dependencies/

If this looks good I can proceed with writing the tests.

[dikwickley]

hi @VallariAg can you review this?

[VallariAg]

@dikwickley please refer my comments above

[dikwickley]

@VallariAg i can't see your comments

[VallariAg]

@dikwickley oh, that's weird! I added a comment to that thread, I wonder if you are able to see that?

But here's what my comments said for AuthServiceMock class:

This class is used only for testing so it should be defined somewhere under /tests directory
You can probably create similar dir structure in /tests as it is in /src.
Also to mock functions, you can look into unittest.mock functions and pytest fixtures
https://docs.python.org/3/library/unittest.mock.html

edit: my bad, I didn't realise that if I don't "submit" a review then the comments would only be visible to me!

[VallariAg]

This class is used only for testing so it should be defined somewhere under /tests directory
You can probably create similar dir structure in /tests as it is in /src.

[VallariAg]

Also to mock functions, you can look into unittest.mock functions and pytest fixtures
https://docs.python.org/3/library/unittest.mock.html

[VallariAg]

@dikwickley ping!

[dikwickley]

Oh you added these 2 weeks ago, I am only able to see them now. I'll make these changes.