fix: use maxlock (not maxtemp) as default in Simple::purge()#13
Draft
Koan-Bot wants to merge 1 commit intocern-mig:masterfrom
Draft
fix: use maxlock (not maxtemp) as default in Simple::purge()#13Koan-Bot wants to merge 1 commit intocern-mig:masterfrom
Koan-Bot wants to merge 1 commit intocern-mig:masterfrom
Conversation
…le.pm
Simple::purge() was using $self->{maxtemp} as the default value for the
maxlock option instead of $self->{maxlock}. This caused locked elements
to be cleaned up after 300 seconds (maxtemp default) instead of the
intended 600 seconds (maxlock default), potentially removing locks that
were still legitimately held.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple::purge() was using
$self->{maxtemp}(300s) as the default for themaxlockoption instead of$self->{maxlock}(600s). This caused lockedelements to be cleaned up too early, potentially removing locks that were
still legitimately held.
One-line fix:
$self->{maxtemp}→$self->{maxlock}on line 307.Supersedes #2 (which included unrelated infrastructure commits).
🤖 Generated by Kōan