fix: use blessed() instead of ref() in Set::_isdq()#14
Draft
Koan-Bot wants to merge 1 commit intocern-mig:masterfrom
Draft
fix: use blessed() instead of ref() in Set::_isdq()#14Koan-Bot wants to merge 1 commit intocern-mig:masterfrom
Koan-Bot wants to merge 1 commit intocern-mig:masterfrom
Conversation
ref() returns a truthy value for unblessed references (e.g. "HASH"), causing $thing->isa() to be called on an unblessed ref, which dies with "Can't call method 'isa' on unblessed reference". blessed() from Scalar::Util correctly returns undef for unblessed references, preventing the crash.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref()returns a truthy value for unblessed references (e.g. "HASH"),causing
\$thing->isa()to be called on an unblessed ref, which dieswith "Can't call method 'isa' on unblessed reference".
blessed()from Scalar::Util correctly returnsundeffor unblessedreferences, preventing the crash.
Supersedes #3 (which included unrelated infrastructure commits).
🤖 Generated by Kōan