fix: add safety guards to remove() in Simple and Normal#17
Draft
Koan-Bot wants to merge 1 commit intocern-mig:masterfrom
Draft
fix: add safety guards to remove() in Simple and Normal#17Koan-Bot wants to merge 1 commit intocern-mig:masterfrom
Koan-Bot wants to merge 1 commit intocern-mig:masterfrom
Conversation
…move() Simple::remove(): add lock verification before attempting to unlink files. Without this, calling remove() on an unlocked element would fail trying to unlink a non-existent .lck file with a confusing error. Normal::remove(): add a retry limit (10) to the lock contention loop in remove(). Without this, an infinite loop could occur if another process keeps re-locking the element during removal.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Both issues are edge cases around concurrent access:
remove()on an unlocked element in Simple.pm would unlink the data file without checking for a lock, potentially leaving orphaned statewhile(1)loop in Normal.pm'sremove()could spin indefinitely under pathological lock contentionTest plan
Supersedes #7 (which was polluted with unrelated commits from fork infrastructure).
🤖 Generated with Claude Code