Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the rules documentation, updates test fixtures, and bumps the local Java SDK version.
- Updates test resources for query naming (timestamp and tag closure)
- Removes the old
RULES_TABLE.mdand updates README to point atRULES.md - Bumps Java version in
.sdkmanrcfrom 11 to 17
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/resources/com/cflint/tests/VariableNameChecker/query_naming_blank_601.expected.txt | Updated the expected timestamp value |
| src/test/resources/com/cflint/tests/VariableNameChecker/query_naming_blank_601.cfc | Added a closing </cfquery> tag in the test fixture |
| RULES_TABLE.md | Deleted old rules table file |
| README.md | Changed link from RULES_TABLE.md to RULES.md |
| .sdkmanrc | Bumped Java SDK version from 11.0.26-zulu to 17.0.12-oracle |
Comments suppressed due to low confidence (2)
.sdkmanrc:3
- [nitpick] Upgrading to Java 17 may require CI/build updates. Verify project compatibility and document the new Java requirement in your README or CI configuration.
java=17.0.12-oracle
README.md:104
- After removing
RULES_TABLE.md, run a repo-wide search for any lingering references to it (in docs or code comments) to avoid broken links.
See [RULES.md](/RULES.md) for more information on rules and their meaning.
| } | ||
| { | ||
| "version" : "", | ||
| "timestamp" : 1749043134, |
There was a problem hiding this comment.
Comparing against a dynamic timestamp makes this test brittle. Consider mocking or parameterizing the timestamp, or assert on its format rather than its exact value.
Suggested change
| "timestamp" : 1749043134, | |
| "timestamp" : "mocked-timestamp", |
ghedwards
reviewed
Jun 12, 2025
.sdkmanrc
Outdated
| # Enable auto-env through the sdkman_auto_env config | ||
| # Add key=value pairs of SDKs to use below | ||
| java=11.0.26-zulu | ||
| java=17.0.12-oracle |
Collaborator
There was a problem hiding this comment.
Any particular reason for this java version? I think java 11 is still fairly prevalent
Author
|
Odd that that upgraded. I was using 11. I will revert.
Mark Drew
…On Thu, 12 Jun 2025 at 20:29, Gareth Edwards ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .sdkmanrc
<#44 (comment)>:
> @@ -1,3 +1,3 @@
# Enable auto-env through the sdkman_auto_env config
# Add key=value pairs of SDKs to use below
-java=11.0.26-zulu
+java=17.0.12-oracle
Any particular reason for this java version? I think java 11 is still
fairly prevalent
—
Reply to this email directly, view it on GitHub
<#44 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABEGHCOENNRQWYWANUM2MT3DHIIXAVCNFSM6AAAAAB7CKK6R2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMRSGM3DMMRZHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Reverting it back to Java 11
cybersonic
commented
Jun 13, 2025
| buildscript { | ||
| repositories { | ||
| mavenLocal() | ||
| jcenter { |
Author
There was a problem hiding this comment.
Removed this as there are errors and I hear it's gone :) see: https://blog.gradle.org/jcenter-shutdown
garethedwards-tass
approved these changes
Jun 20, 2025
Author
|
Thank you @garethedwards-tass ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the old rules.md file that had a long unreadable list with the table version. Updating the links